Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Do not fail on missing dependency cache #13492

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Aug 28, 2024

This PR updates CI to never fail on cache misses. Instead, we rerun install or rebuild the tarballs, if necessary.

One tricky aspect of this is that yarn install will fail when running on node 14, because some dependencies do not work with it. We "fix" this by temporarily installing the default node version in this case, run yarn install, then revert to node 14.

@mydea mydea self-assigned this Aug 28, 2024
@mydea mydea force-pushed the fn/do-not-fail-dependency-cache branch from 8f19230 to 1f6ec07 Compare August 28, 2024 08:48
@mydea mydea marked this pull request as ready for review August 28, 2024 08:49
@mydea mydea merged commit 977c508 into develop Aug 28, 2024
128 checks passed
@mydea mydea deleted the fn/do-not-fail-dependency-cache branch August 28, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants