core(lint): Add custom no-focused-tests
and no-skipped-tests
rules
#13461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
it.skip
andit.only
usage is not correctly flagged in vitest files by our jest eslint plugin. To fix this, I initially wanted to add eslint-plugin-vitest but realized it requires Eslint 9 which we can't use (we're on eslint 7) because it requires Node 18 🙃So instead, this PR adds two simple custom rules to ignore
(it|test|describe).(skip|only)
. These rules now also flag vitest-basedskip
andonly
functions but led to duplications with the two rules fromeslint-plugin-jest
. So this PR also disables the jest versions in favour of the custom rules. To be clear, the custom rules are likely a bit less robust than the jest/vitest version but until we can use the actual vitest plugin, I think it's fine to stay with our custom version.closes #13429