Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Improve size-limit CI action #13348

Merged
merged 9 commits into from
Aug 14, 2024
Merged

ci: Improve size-limit CI action #13348

merged 9 commits into from
Aug 14, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Aug 13, 2024 •
edited
Loading

This improves a few things in our size-limit CI action:

  1. Show change in bytes, in addition to the change in percentage.
  2. Add a link below the table to the base comparison run.
  3. If we detect that the workflow run we used as base is not the latest one, show a warning on top.

image

@mydea mydea self-assigned this Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 13, 2024 •
edited
Loading

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 22.5 KB - -
@sentry/browser (incl. Tracing) 34.85 KB - -
@sentry/browser (incl. Tracing, Replay) 71.19 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 64.45 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 75.53 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 88.17 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90 KB - -
@sentry/browser (incl. metrics) 26.81 KB - -
@sentry/browser (incl. Feedback) 39.47 KB - -
@sentry/browser (incl. sendFeedback) 27.13 KB - -
@sentry/browser (incl. FeedbackAsync) 31.79 KB - -
@sentry/react 25.26 KB - -
@sentry/react (incl. Tracing) 37.83 KB - -
@sentry/vue 26.65 KB - -
@sentry/vue (incl. Tracing) 36.67 KB - -
@sentry/svelte 22.64 KB - -
CDN Bundle 23.73 KB - -
CDN Bundle (incl. Tracing) 36.49 KB - -
CDN Bundle (incl. Tracing, Replay) 70.81 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.06 KB - -
CDN Bundle - uncompressed 69.61 KB - -
CDN Bundle (incl. Tracing) - uncompressed 108.27 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.52 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 232.41 KB - -
@sentry/nextjs (client) 37.59 KB - -
@sentry/sveltekit (client) 35.45 KB - -
@sentry/node 115.71 KB - -
@sentry/node - without tracing 90.1 KB -0.01% -1 B 🔽
@sentry/aws-serverless 99.51 KB - -

View base workflow run

@mydea mydea force-pushed the fn/size-limit-improvements branch 2 times, most recently from 3c0d723 to cb42ec2 Compare August 14, 2024 08:07
@mydea mydea marked this pull request as ready for review August 14, 2024 08:09
s1gr1d
s1gr1d approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so nice, thank you!

@andreiborza
Copy link
Member

Great change, really like the change in bytes addition.

andreiborza
andreiborza reviewed Aug 14, 2024
View reviewed changes
dev-packages/size-limit-gh-action/index.mjs Show resolved Hide resolved
dev-packages/size-limit-gh-action/index.mjs Outdated

if (baseIsNotLatest) {
bodyParts.push(
'⚠️ **Warning:** Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: How about adding a line of what could be done to get correct results?

@mydea mydea force-pushed the fn/size-limit-improvements branch from aabe481 to 117430a Compare August 14, 2024 09:45
@mydea mydea merged commit 0af5b4f into develop Aug 14, 2024
98 checks passed
@mydea mydea deleted the fn/size-limit-improvements branch August 14, 2024 09:58
Zen-cronic pushed a commit to Zen-cronic/sentry-javascript that referenced this pull request Aug 26, 2024
@mydea @Zen-cronic
ci: Improve size-limit CI action (getsentry#13348)
fa93e11 
This improves a few things in our size-limit CI action:

1. Show change in bytes, in addition to the change in percentage. 
2. Add a link below the table to the base comparison run.
3. If we detect that the workflow run we used as base is not the latest
one, show a warning on top.


![image](https://github.com/user-attachments/assets/4678ff04-a463-4579-ad91-74cbf9b7d781)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreiborza andreiborza andreiborza approved these changes

@s1gr1d s1gr1d s1gr1d approved these changes

@chargome chargome Awaiting requested review from chargome

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mydea @andreiborza @s1gr1d