Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ref): Avoid some unnecessary conditions in tests #12493

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jun 14, 2024

This updates some tests to avoid unnecessary conditions.

Extracted this out while looking at enabling eslint no-uncessary-condition, as this can be done without much reviewing.

@mydea mydea self-assigned this Jun 14, 2024
@mydea mydea requested a review from a team as a code owner June 14, 2024 08:48
@mydea mydea force-pushed the fn/test-unnecessary-conditions branch from ae660ac to de8996d Compare June 14, 2024 11:01
Copy link
Contributor

github-actions bot commented Jun 14, 2024

size-limit report 📦

Path Size
@sentry/browser 22.03 KB (0%)
@sentry/browser (incl. Tracing) 33.2 KB (0%)
@sentry/browser (incl. Tracing, Replay) 68.94 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.27 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.01 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.17 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 86.99 KB (0%)
@sentry/browser (incl. metrics) 26.21 KB (0%)
@sentry/browser (incl. Feedback) 38.22 KB (0%)
@sentry/browser (incl. sendFeedback) 26.62 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.17 KB (0%)
@sentry/react 24.8 KB (0%)
@sentry/react (incl. Tracing) 36.28 KB (0%)
@sentry/vue 26.03 KB (0%)
@sentry/vue (incl. Tracing) 35.06 KB (0%)
@sentry/svelte 22.17 KB (0%)
CDN Bundle 23.36 KB (0%)
CDN Bundle (incl. Tracing) 34.89 KB (0%)
CDN Bundle (incl. Tracing, Replay) 68.99 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.16 KB (0%)
CDN Bundle - uncompressed 68.68 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 103.29 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 213.74 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 226.2 KB (0%)
@sentry/nextjs (client) 35.61 KB (0%)
@sentry/sveltekit (client) 33.83 KB (0%)
@sentry/node 112.01 KB (0%)
@sentry/node - without tracing 89.47 KB (0%)
@sentry/aws-serverless 98.53 KB (-0.01% 🔽)

@mydea mydea merged commit 1bb86db into develop Jun 17, 2024
113 checks passed
@mydea mydea deleted the fn/test-unnecessary-conditions branch June 17, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants