Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Add option to pass in custom record fn #12486

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Jun 13, 2024

Bringing back #8647 but it would be nice to test new versions of rrweb without having to bundle it with our replay SDK.

* Uses clean `Array.from` implementation
* Revert css parsing (player)
* Implements multitouch gestures (player)
* Many upstream fixes
Bringing back #8647 but it would be nice to test new versions of rrweb without having to bundle it with our replay SDK.
@billyvg billyvg force-pushed the feat-replay-allow-external-record-fn branch from b5c174a to ed7be20 Compare June 13, 2024 20:16
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 22.04 KB (0%)
@sentry/browser (incl. Tracing) 33.23 KB (0%)
@sentry/browser (incl. Tracing, Replay) 69.32 KB (+0.53% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.61 KB (+0.55% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.72 KB (+0.97% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.55 KB (+0.46% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.38 KB (+0.44% 🔺)
@sentry/browser (incl. metrics) 26.23 KB (0%)
@sentry/browser (incl. Feedback) 38.24 KB (0%)
@sentry/browser (incl. sendFeedback) 26.63 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.18 KB (0%)
@sentry/react 24.81 KB (0%)
@sentry/react (incl. Tracing) 36.27 KB (0%)
@sentry/vue 26.05 KB (0%)
@sentry/vue (incl. Tracing) 35.08 KB (0%)
@sentry/svelte 22.17 KB (0%)
CDN Bundle 23.39 KB (0%)
CDN Bundle (incl. Tracing) 34.91 KB (0%)
CDN Bundle (incl. Tracing, Replay) 69.4 KB (+0.55% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.51 KB (+0.5% 🔺)
CDN Bundle - uncompressed 68.71 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 103.3 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 214.96 KB (+0.57% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 227.43 KB (+0.54% 🔺)
@sentry/nextjs (client) 35.63 KB (0%)
@sentry/sveltekit (client) 33.86 KB (0%)
@sentry/node 111.96 KB (0%)
@sentry/node - without tracing 89.43 KB (0%)
@sentry/aws-serverless 98.49 KB (+0.01% 🔺)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant