-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test(e2e): Enable ESM loader test (#12020)
Supersedes #11912 I just cleaned up and renamed this to align with other things
- Loading branch information
Showing
34 changed files
with
162 additions
and
78 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ | |
| "build": "react-scripts build", | ||
| "test": "react-scripts test", | ||
| "eject": "react-scripts eject", | ||
| "clean": "npx rimraf node_modules,pnpm-lock.yaml", | ||
| "clean": "npx rimraf node_modules pnpm-lock.yaml", | ||
| "test:build": "pnpm install && pnpm build", | ||
| "test:build-ts3.8": "pnpm install && pnpm add [email protected] && pnpm build", | ||
| "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 0 additions & 33 deletions
33
dev-packages/e2e-tests/test-applications/esm-loader-node-express-app/tests/server.test.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
13 changes: 5 additions & 8 deletions
13
.../esm-loader-node-express-app/package.json → ...ions/node-express-esm-loader/package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
dev-packages/e2e-tests/test-applications/node-express-esm-loader/src/instrument.mjs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import * as Sentry from '@sentry/node'; | ||
|
|
||
| Sentry.init({ | ||
| environment: 'qa', // dynamic sampling bias to keep transactions | ||
| dsn: process.env.E2E_TEST_DSN, | ||
| tunnel: `http://localhost:3031/`, // proxy server | ||
| tracesSampleRate: 1, | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
117 changes: 117 additions & 0 deletions
117
dev-packages/e2e-tests/test-applications/node-express-esm-loader/tests/server.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| import { expect, test } from '@playwright/test'; | ||
| import { waitForError, waitForTransaction } from '@sentry-internal/event-proxy-server'; | ||
|
|
||
| test('Should record exceptions captured inside handlers', async ({ request }) => { | ||
| const errorEventPromise = waitForError('node-express-esm-loader', errorEvent => { | ||
| return !!errorEvent?.exception?.values?.[0]?.value?.includes('This is an error'); | ||
| }); | ||
|
|
||
| await request.get('/test-error'); | ||
|
|
||
| await expect(errorEventPromise).resolves.toBeDefined(); | ||
| }); | ||
|
|
||
| test('Should record a transaction for a parameterless route', async ({ request }) => { | ||
| const transactionEventPromise = waitForTransaction('node-express-esm-loader', transactionEvent => { | ||
| return transactionEvent?.transaction === 'GET /test-success'; | ||
| }); | ||
|
|
||
| await request.get('/test-success'); | ||
|
|
||
| await expect(transactionEventPromise).resolves.toBeDefined(); | ||
| }); | ||
|
|
||
| test('Should record a transaction for route with parameters', async ({ request }) => { | ||
| const transactionEventPromise = waitForTransaction('node-express-esm-loader', transactionEvent => { | ||
| return transactionEvent.contexts?.trace?.data?.['http.target'] === '/test-transaction/1'; | ||
| }); | ||
|
|
||
| await request.get('/test-transaction/1'); | ||
|
|
||
| const transactionEvent = await transactionEventPromise; | ||
|
|
||
| expect(transactionEvent).toBeDefined(); | ||
| expect(transactionEvent.transaction).toEqual('GET /test-transaction/:param'); | ||
| expect(transactionEvent.contexts?.trace?.data).toEqual( | ||
| expect.objectContaining({ | ||
| 'http.flavor': '1.1', | ||
| 'http.host': 'localhost:3030', | ||
| 'http.method': 'GET', | ||
| 'http.response.status_code': 200, | ||
| 'http.route': '/test-transaction/:param', | ||
| 'http.scheme': 'http', | ||
| 'http.status_code': 200, | ||
| 'http.status_text': 'OK', | ||
| 'http.target': '/test-transaction/1', | ||
| 'http.url': 'http://localhost:3030/test-transaction/1', | ||
| 'http.user_agent': expect.any(String), | ||
| 'net.host.ip': expect.any(String), | ||
| 'net.host.name': 'localhost', | ||
| 'net.host.port': 3030, | ||
| 'net.peer.ip': expect.any(String), | ||
| 'net.peer.port': expect.any(Number), | ||
| 'net.transport': 'ip_tcp', | ||
| 'otel.kind': 'SERVER', | ||
| 'sentry.op': 'http.server', | ||
| 'sentry.origin': 'auto.http.otel.http', | ||
| 'sentry.sample_rate': 1, | ||
| 'sentry.source': 'route', | ||
| url: 'http://localhost:3030/test-transaction/1', | ||
| }), | ||
| ); | ||
|
|
||
| const spans = transactionEvent.spans || []; | ||
| expect(spans).toContainEqual({ | ||
| data: { | ||
| 'express.name': 'query', | ||
| 'express.type': 'middleware', | ||
| 'http.route': '/', | ||
| 'otel.kind': 'INTERNAL', | ||
| 'sentry.origin': 'auto.http.otel.express', | ||
| }, | ||
| description: 'middleware - query', | ||
| origin: 'auto.http.otel.express', | ||
| parent_span_id: expect.any(String), | ||
| span_id: expect.any(String), | ||
| start_timestamp: expect.any(Number), | ||
| status: 'ok', | ||
| timestamp: expect.any(Number), | ||
| trace_id: expect.any(String), | ||
| }); | ||
|
|
||
| expect(spans).toContainEqual({ | ||
| data: { | ||
| 'express.name': 'expressInit', | ||
| 'express.type': 'middleware', | ||
| 'http.route': '/', | ||
| 'otel.kind': 'INTERNAL', | ||
| 'sentry.origin': 'auto.http.otel.express', | ||
| }, | ||
| description: 'middleware - expressInit', | ||
| origin: 'auto.http.otel.express', | ||
| parent_span_id: expect.any(String), | ||
| span_id: expect.any(String), | ||
| start_timestamp: expect.any(Number), | ||
| status: 'ok', | ||
| timestamp: expect.any(Number), | ||
| trace_id: expect.any(String), | ||
| }); | ||
|
|
||
| expect(spans).toContainEqual({ | ||
| data: { | ||
| 'express.name': '/test-transaction/:param', | ||
| 'express.type': 'request_handler', | ||
| 'http.route': '/test-transaction/:param', | ||
| 'otel.kind': 'INTERNAL', | ||
| 'sentry.origin': 'auto.http.otel.express', | ||
| }, | ||
| description: 'request handler - /test-transaction/:param', | ||
| origin: 'auto.http.otel.express', | ||
| parent_span_id: expect.any(String), | ||
| span_id: expect.any(String), | ||
| start_timestamp: expect.any(Number), | ||
| status: 'ok', | ||
| timestamp: expect.any(Number), | ||
| trace_id: expect.any(String), | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.