rename resource module to asset module #10047
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 285 bytes ⬆️
|
There was a problem hiding this comment.
Changes look fine but you'll want to double check the following before merging:
- Add redirect for this page to middleware.ts (see https://docs.sentry.io/contributing/pages/redirects/#add-a-new-redirect-in-middlewarets-recommended)
- Are the widgets affected by this change? Might need to update these sections:
- https://docs.sentry.io/product/performance/filters-display/widgets/#most-time-consuming-resources
- https://docs.sentry.io/product/performance/filters-display/widgets/#slow-resource-ops
- https://docs.sentry.io/product/performance/filters-display/#actionable-widgets
- Since you're changing the file name, will also want to do a search to update any links that were going directly to the resources page (for example, links here https://docs.sentry.io/product/performance/filters-display/widgets/#most-time-consuming-resources)
We should also update the arcades included in these docs. I can help with that; just give me a heads up for when this change is planning to launch!
|
@vivianyentran we plan to release this on June 5th, r we able to update the arcades by then? Also, do the links need be changed? |
|
@DominikB2014 Yes, we should be able to update the arcades by then. Are all the changes live in the sentry org to capture screenshots? |
|
@DominikB2014 Yes, you should also update any links that point to the old path |
@vivianyentran the updates should be live eod today, I'll follow up with you on slack when it's done! |
Renaming the `resources` module to `assets` resonates better with FE devs. This does all the renaming in sentry itself, and there's another PR up for docs getsentry/sentry-docs#10047 --------- Co-authored-by: George Gritsouk <[email protected]>
Asset module probably resonates better with FE devs, so we should rename the module