Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar of sentences mentioning OpenTelemetry #10034

Merged
merged 2 commits into from
May 16, 2024

Conversation

stephenwade
Copy link
Contributor

DESCRIBE YOUR PR

  • Fix weird sentence construction when mentioning OpenTelemetry
    • Before: "though if you use OpenTelemetry-native APIs to start spans, and Sentry will pick up everything automatically."
    • After: "though if you use OpenTelemetry-native APIs to start spans, Sentry will pick up everything automatically."
  • Remove duplicate text about not needing to know what OpenTelemetry is
    • Before: "You do not need to know or understand what OpenTelemetry is in order to use Sentry. We set up OpenTelemetry under the hood, no knowledge of it is required in order to get started."
    • After: "You do not need to know or understand what OpenTelemetry is in order to use Sentry. We set up OpenTelemetry under the hood."

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented May 15, 2024

@stephenwade is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 4:41pm

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these edits! Made a slight adjustment.

@vivianyentran vivianyentran enabled auto-merge (squash) May 16, 2024 16:26
@vivianyentran vivianyentran merged commit 324eb07 into getsentry:master May 16, 2024
6 checks passed
@stephenwade stephenwade deleted the otel-grammar branch May 16, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants