Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: non-nullable privacy setting #2382

Open
wants to merge 1 commit into
base: feat/redact-screenshots-via-view-hierarchy
Choose a base branch
from

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Oct 30, 2024

This suggests a change on top of another PR (#2361) - I think it would be more user-friendly to provide the options.experimental.privacy as a non-nullable field so users can set its properties directly.

See code comments for some more details

Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- non-nullable privacy setting ([#2382](https://github.com/getsentry/sentry-dart/pull/2382))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against a82a879

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.08%. Comparing base (57a0823) to head (a82a879).

Additional details and impacted files
@@                              Coverage Diff                               @@
##           feat/redact-screenshots-via-view-hierarchy    #2382      +/-   ##
==============================================================================
+ Coverage                                       84.93%   85.08%   +0.14%     
==============================================================================
  Files                                              81       81              
  Lines                                            2808     2809       +1     
==============================================================================
+ Hits                                             2385     2390       +5     
+ Misses                                            423      419       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant