Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiling: new continuous profiling API #4952

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

armcknight
Copy link
Member

This is an epic feature branch draft PR, into which other branches will be merged for the duration of the work to introduce the changes in #4851

@armcknight armcknight force-pushed the armcknight/git-chain/profiling/new-continuous-apis/0-topic-branch branch from c2615f1 to ee673bf Compare March 6, 2025 23:31
armcknight and others added 10 commits March 7, 2025 10:14
This PR reports fatal app hangs without session updates, only when the
experimental option enableAppHangTrackingV2 is enabled. Updating the
session will be done in a follow-up PR.

This fixes the first part of GH-4260.

Co-authored-by: Philip Niedertscheider <[email protected]>
This PR fixes wrongly finishing the TTFD span as the deadline exceeded
when the user calls finishSpansIfNotFinished, and the
UIViewControllerPerformanceTracker calls finishSpansIfNotFinished before
a new frame gets drawn. This happened for a customer using a
SplashScreenUIViewController. Now, the TimeToDisplayTracker finishes the
TTFD span in finishSpansIfNotFinished when the user called
finishSpansIfNotFinished.
Skip creating user interaction transactions that would time out without
any children.

Fixes GH-2407
Check in the HTTPTransport if the server returns a 200 HTTP status code.
Only if it does delete the envelope. If not, stop sending.

Fixes GH-4458
The SDK only reports watchdog terminations when the app is the
foreground. Previously, watchdog terminations events didn't have the app
context in_foreground set to true. This is fixed now.

Fixes GH-4765
Copy link

github-actions bot commented Mar 8, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1229.65 ms 1252.16 ms 22.51 ms
Size 22.30 KiB 823.44 KiB 801.13 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ab0012c 1209.06 ms 1228.78 ms 19.72 ms
825f0cb 1220.53 ms 1236.18 ms 15.65 ms
ae9c51b 1244.85 ms 1264.33 ms 19.47 ms
8aec30e 1249.29 ms 1252.63 ms 3.35 ms
b9fc537 1219.69 ms 1231.80 ms 12.12 ms
dbb4b19 1246.02 ms 1259.87 ms 13.85 ms
9202018 1225.77 ms 1250.06 ms 24.29 ms
e887ddc 1234.71 ms 1244.22 ms 9.50 ms
866c529 1223.76 ms 1244.27 ms 20.52 ms
fff4a70 1236.59 ms 1249.11 ms 12.52 ms

App size

Revision Plain With Sentry Diff
ab0012c 22.85 KiB 415.09 KiB 392.24 KiB
825f0cb 22.31 KiB 771.42 KiB 749.10 KiB
ae9c51b 22.85 KiB 411.13 KiB 388.28 KiB
8aec30e 21.58 KiB 616.76 KiB 595.18 KiB
b9fc537 21.58 KiB 676.19 KiB 654.61 KiB
dbb4b19 22.30 KiB 750.03 KiB 727.73 KiB
9202018 22.30 KiB 749.70 KiB 727.40 KiB
e887ddc 21.58 KiB 616.76 KiB 595.18 KiB
866c529 22.31 KiB 780.84 KiB 758.53 KiB
fff4a70 21.58 KiB 707.28 KiB 685.70 KiB

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.498%. Comparing base (c964075) to head (c8e496f).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4952       +/-   ##
=============================================
+ Coverage   92.470%   92.498%   +0.028%     
=============================================
  Files          666       666               
  Lines        78926     78933        +7     
  Branches     28572     28592       +20     
=============================================
+ Hits         72983     73012       +29     
+ Misses        5845      5823       -22     
  Partials        98        98               

see 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c964075...c8e496f. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants