Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add warning for experimental feature #4869

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

philprime
Copy link
Contributor

Splits up the initializer of SentryTracedView into one with the parameter waitForFullDisplay and one without. The one with the parameter is marked as experimental.

See #4162

#skip-changelog

@philprime philprime requested a review from kahest February 19, 2025 10:28
@philprime philprime self-assigned this Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.240%. Comparing base (9ef38ea) to head (a2ff2a7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/SentrySwiftUI/SentryTracedView.swift 0.000% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4869       +/-   ##
=============================================
- Coverage   92.257%   92.240%   -0.017%     
=============================================
  Files          659       659               
  Lines        77328     77328               
  Branches     27945     27937        -8     
=============================================
- Hits         71341     71328       -13     
- Misses        5891      5902       +11     
- Partials        96        98        +2     
Files with missing lines Coverage Δ
Sources/SentrySwiftUI/SentryTracedView.swift 61.764% <0.000%> (-4.552%) ⬇️

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ef38ea...a2ff2a7. Read the comment docs.

Copy link

github-actions bot commented Feb 20, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1238.14 ms 1253.21 ms 15.07 ms
Size 22.31 KiB 820.89 KiB 798.58 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8c9d1d4 1239.13 ms 1253.00 ms 13.87 ms
76c2ac7 1226.84 ms 1247.22 ms 20.39 ms
a8e28a3 1241.41 ms 1257.29 ms 15.88 ms
23e2db5 1240.96 ms 1253.86 ms 12.90 ms
89d72e7 1222.60 ms 1252.78 ms 30.18 ms
69d8759 1235.71 ms 1241.34 ms 5.63 ms
070db34 1228.64 ms 1240.24 ms 11.61 ms
07ea386 1228.86 ms 1255.31 ms 26.45 ms
e072ad1 1221.35 ms 1237.48 ms 16.13 ms
27f970b 1229.88 ms 1249.56 ms 19.69 ms

App size

Revision Plain With Sentry Diff
8c9d1d4 21.58 KiB 706.97 KiB 685.39 KiB
76c2ac7 21.58 KiB 695.48 KiB 673.90 KiB
a8e28a3 21.90 KiB 726.14 KiB 704.24 KiB
23e2db5 20.76 KiB 434.97 KiB 414.21 KiB
89d72e7 20.76 KiB 431.87 KiB 411.11 KiB
69d8759 20.76 KiB 393.05 KiB 372.29 KiB
070db34 21.58 KiB 574.17 KiB 552.59 KiB
07ea386 22.30 KiB 747.52 KiB 725.22 KiB
e072ad1 21.58 KiB 625.82 KiB 604.24 KiB
27f970b 21.58 KiB 706.97 KiB 685.39 KiB

Previous results on branch: philprime/ttfd-warning

Startup times

Revision Plain With Sentry Diff
dcfd8c3 1232.65 ms 1249.71 ms 17.06 ms

App size

Revision Plain With Sentry Diff
dcfd8c3 22.31 KiB 820.52 KiB 798.20 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants