-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impr: Add uptime to SDK log messages #4781
base: main
Are you sure you want to change the base?
Conversation
Add the system uptime to the SDK log messages to know precisely when the logger logs. This can help when investigating issues by reading the SDK log messages.
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b9d59f7 | 1250.71 ms | 1257.78 ms | 7.06 ms |
9ce54cc | 1230.31 ms | 1237.20 ms | 6.90 ms |
72c8d84 | 1238.96 ms | 1247.34 ms | 8.38 ms |
f8833c4 | 1236.45 ms | 1252.82 ms | 16.37 ms |
7cd187e | 1243.04 ms | 1244.79 ms | 1.75 ms |
253bb71 | 1221.62 ms | 1250.82 ms | 29.20 ms |
3eb2a52 | 1241.48 ms | 1250.50 ms | 9.02 ms |
21fd61f | 1226.42 ms | 1247.52 ms | 21.10 ms |
1bbcb9c | 1189.61 ms | 1223.50 ms | 33.89 ms |
be51b56 | 1220.84 ms | 1249.36 ms | 28.52 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b9d59f7 | 22.85 KiB | 405.77 KiB | 382.93 KiB |
9ce54cc | 21.58 KiB | 573.71 KiB | 552.13 KiB |
72c8d84 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
f8833c4 | 21.58 KiB | 422.66 KiB | 401.08 KiB |
7cd187e | 20.76 KiB | 401.65 KiB | 380.89 KiB |
253bb71 | 20.76 KiB | 393.37 KiB | 372.60 KiB |
3eb2a52 | 20.76 KiB | 393.38 KiB | 372.62 KiB |
21fd61f | 20.76 KiB | 435.50 KiB | 414.74 KiB |
1bbcb9c | 20.76 KiB | 426.10 KiB | 405.34 KiB |
be51b56 | 20.76 KiB | 432.20 KiB | 411.44 KiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4781 +/- ##
=============================================
- Coverage 91.395% 91.390% -0.005%
=============================================
Files 627 627
Lines 74573 74594 +21
Branches 26823 26838 +15
=============================================
+ Hits 68156 68172 +16
- Misses 6319 6323 +4
- Partials 98 99 +1
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't send this data off-device, see https://developer.apple.com/documentation/bundleresources/app-privacy-configuration/nsprivacyaccessedapitypes/nsprivacyaccessedapitype?language=objc (search for NSPrivacyAccessedAPICategorySystemBootTime
).
The only exception is derived data that calculates a duration. Otherwise, we can't send the raw value or other derivations off-device.
📜 Description
Add the system uptime to the SDK log messages to know precisely when the logger logs. This can help when investigating issues by reading the SDK log messages.
💡 Motivation and Context
For investigating the raw logs of flaky tests this can be highly useful to understand exactly where a test might have hanged.
💚 How did you test it?
Unit tests.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps