Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: FramesTrackingIntegration remove stop #3978

Merged
merged 1 commit into from
May 16, 2024

Conversation

philipphofmann
Copy link
Member

Remove not needed stop method.

Came up while investigating #3700.

#skip-changelog

Remove not needed stop method.
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.805%. Comparing base (1ac58a6) to head (8a78a2e).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3978       +/-   ##
=============================================
- Coverage   90.870%   90.805%   -0.066%     
=============================================
  Files          594       594               
  Lines        46083     46081        -2     
  Branches     16442     16458       +16     
=============================================
- Hits         41876     41844       -32     
- Misses        4027      4057       +30     
  Partials       180       180               
Files Coverage Δ
Sources/Sentry/SentryFramesTrackingIntegration.m 100.000% <ø> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac58a6...8a78a2e. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1218.22 ms 1235.78 ms 17.55 ms
Size 21.58 KiB 626.08 KiB 604.50 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c021422 1199.15 ms 1222.20 ms 23.05 ms
438e21a 1237.47 ms 1255.24 ms 17.77 ms
ed68562 1238.45 ms 1251.57 ms 13.12 ms
83887af 1196.94 ms 1206.82 ms 9.88 ms
965db8a 1211.61 ms 1226.60 ms 14.99 ms
88ca9d8 1228.09 ms 1254.79 ms 26.70 ms
42ef6ba 1234.35 ms 1252.29 ms 17.94 ms
72c8d84 1266.16 ms 1267.57 ms 1.41 ms
de033da 1216.91 ms 1222.84 ms 5.92 ms
7fe37ab 1236.10 ms 1258.83 ms 22.73 ms

App size

Revision Plain With Sentry Diff
c021422 20.76 KiB 435.64 KiB 414.88 KiB
438e21a 20.76 KiB 434.62 KiB 413.86 KiB
ed68562 22.84 KiB 403.24 KiB 380.39 KiB
83887af 21.58 KiB 419.64 KiB 398.06 KiB
965db8a 22.84 KiB 403.24 KiB 380.39 KiB
88ca9d8 21.58 KiB 612.82 KiB 591.24 KiB
42ef6ba 21.58 KiB 417.86 KiB 396.28 KiB
72c8d84 22.85 KiB 408.88 KiB 386.03 KiB
de033da 21.58 KiB 418.15 KiB 396.57 KiB
7fe37ab 21.58 KiB 542.28 KiB 520.70 KiB

@philipphofmann philipphofmann merged commit 853d797 into main May 16, 2024
69 of 70 checks passed
@philipphofmann philipphofmann deleted the ref/frames-tracking-integration branch May 16, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants