Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(profiling): move timer mgmt out of SentryProfiler #3953

Conversation

armcknight
Copy link
Member

#skip-changelog; for #3555

A refactor that was asked about in #3913 (comment)

…ure of profiler frequency; remove duplicate declaration of threadSanitizerIsPresent(); move some SentryProfiler.mm imports into SENTRY_HAS_UIKIT gate
…ctly from dep container in profile serialization
- move old profiler control logic to new SentryLegacyProfiler class,
    leaving SentryProfiler to only contain the state and internal
    reference to SamplingProfiler
…continuous-profiling/4-refactoring/3-renames
…ion/4-launch-profiling' into armcknight/feat/3555-continuous-profiling/5-implementation/5-renames
…ion/4-launch-profiling' into armcknight/feat/3555-continuous-profiling/5-implementation/5-renames
…ion/5-renames' into armcknight/feat/3555-continuous-profiling/5-implementation/6-move-timer-out-of-profiler-instance
…continuous-profiling/5-implementation/5-renames
…ion/5-renames' into armcknight/feat/3555-continuous-profiling/5-implementation/6-move-timer-out-of-profiler-instance
…mer factory override didnt work because the override was overwritten by the tracers vended timer; it doesnt work when muliple timers are vended
Base automatically changed from armcknight/feat/3555-continuous-profiling/5-implementation/5-renames to main May 16, 2024 20:26
…continuous-profiling/5-implementation/6-move-timer-out-of-profiler-instance
@armcknight armcknight merged commit a9ac2b2 into main May 16, 2024
67 of 70 checks passed
@armcknight armcknight deleted the armcknight/feat/3555-continuous-profiling/5-implementation/6-move-timer-out-of-profiler-instance branch May 16, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants