ref(profiling): move timer mgmt out of SentryProfiler #3953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to separate code unit
…ure of profiler frequency; remove duplicate declaration of threadSanitizerIsPresent(); move some SentryProfiler.mm imports into SENTRY_HAS_UIKIT gate
…ctly from dep container in profile serialization
- move old profiler control logic to new SentryLegacyProfiler class,
leaving SentryProfiler to only contain the state and internal
reference to SamplingProfiler
…and SentryLegacyProfiler+Test
…g underscore for public members
…continuous-profiling/4-refactoring/3-renames
…ion/4-launch-profiling' into armcknight/feat/3555-continuous-profiling/5-implementation/5-renames
…ion/4-launch-profiling' into armcknight/feat/3555-continuous-profiling/5-implementation/5-renames
…ion/5-renames' into armcknight/feat/3555-continuous-profiling/5-implementation/6-move-timer-out-of-profiler-instance
…continuous-profiling/5-implementation/5-renames
…ion/5-renames' into armcknight/feat/3555-continuous-profiling/5-implementation/6-move-timer-out-of-profiler-instance
…mer factory override didnt work because the override was overwritten by the tracers vended timer; it doesnt work when muliple timers are vended
Base automatically changed from
armcknight/feat/3555-continuous-profiling/5-implementation/5-renames
to
main
May 16, 2024 20:26
…continuous-profiling/5-implementation/6-move-timer-out-of-profiler-instance
armcknight
deleted the
armcknight/feat/3555-continuous-profiling/5-implementation/6-move-timer-out-of-profiler-instance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog; for #3555
A refactor that was asked about in #3913 (comment)