-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(profiling): continuous profiling from launch #3938
feat(profiling): continuous profiling from launch #3938
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d9cd5f1 | 1234.14 ms | 1257.69 ms | 23.54 ms |
257c2a9 | 1231.45 ms | 1252.12 ms | 20.67 ms |
6001822 | 1234.49 ms | 1265.20 ms | 30.71 ms |
e24290f | 1239.94 ms | 1248.28 ms | 8.34 ms |
973d574 | 1228.92 ms | 1246.79 ms | 17.87 ms |
8aba9c4 | 1236.94 ms | 1248.29 ms | 11.35 ms |
6943de0 | 1235.98 ms | 1246.88 ms | 10.90 ms |
7419285 | 1209.53 ms | 1244.72 ms | 35.19 ms |
408f43e | 1229.31 ms | 1247.52 ms | 18.21 ms |
69d2789 | 1224.14 ms | 1247.17 ms | 23.02 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d9cd5f1 | 21.58 KiB | 544.73 KiB | 523.14 KiB |
257c2a9 | 20.76 KiB | 401.36 KiB | 380.60 KiB |
6001822 | 22.85 KiB | 410.98 KiB | 388.13 KiB |
e24290f | 22.84 KiB | 403.51 KiB | 380.66 KiB |
973d574 | 21.58 KiB | 542.38 KiB | 520.80 KiB |
8aba9c4 | 21.58 KiB | 544.72 KiB | 523.14 KiB |
6943de0 | 20.76 KiB | 393.33 KiB | 372.57 KiB |
7419285 | 20.76 KiB | 432.99 KiB | 412.22 KiB |
408f43e | 21.58 KiB | 573.17 KiB | 551.59 KiB |
69d2789 | 21.58 KiB | 548.09 KiB | 526.50 KiB |
Previous results on branch: armcknight/feat/3555-continuous-profiling/5-implementation/4-launch-profiling
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
21d1971 | 1246.59 ms | 1255.06 ms | 8.47 ms |
1f9a916 | 1212.57 ms | 1241.27 ms | 28.69 ms |
4cc09ac | 1245.08 ms | 1257.56 ms | 12.48 ms |
db1c44f | 1236.31 ms | 1241.31 ms | 4.99 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
21d1971 | 21.58 KiB | 630.71 KiB | 609.13 KiB |
1f9a916 | 21.58 KiB | 630.20 KiB | 608.62 KiB |
4cc09ac | 21.58 KiB | 621.09 KiB | 599.51 KiB |
db1c44f | 21.58 KiB | 630.11 KiB | 608.53 KiB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3938 +/- ##
=============================================
+ Coverage 90.856% 90.955% +0.099%
=============================================
Files 594 594
Lines 46392 46481 +89
Branches 16620 16661 +41
=============================================
+ Hits 42150 42277 +127
+ Misses 4062 4026 -36
+ Partials 180 178 -2
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
8a829a6
to
a24c529
Compare
f91f24f
to
b102627
Compare
b102627
to
363cb2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, almost LGTM 😸
1fa9daf
to
8b6a180
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
for #3555; #skip-changelog
This PR makes the necessary changes to app launch profiling logic to work with the continuous profiler, since we'll no longer be using SentryTracer to manage starting the profiler, instead starting it directly.