Split out progress bar logic from API #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
changed the base branch from
master
to
szokeasaurusrex/progress-bar-refactor
szokeasaurusrex
changed the title
loewenheim
approved these changes
Apr 23, 2024
szokeasaurusrex
force-pushed
the
szokeasaurusrex/progress-bar-refactor
branch
from
77ede42
to
ceec4b7
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/progress-bar-mode-refactor
branch
from
d3a3fae
to
a2bb250
Compare
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
szokeasaurusrex
force-pushed
the
szokeasaurusrex/progress-bar-mode-refactor
branch
from
a2bb250
to
a2cb5e7
Compare
szokeasaurusrex
changed the base branch from
szokeasaurusrex/progress-bar-refactor
to
master
This code is more closely related to the utils module's progress bar code than to the api code. Ref #2008
szokeasaurusrex
force-pushed
the
szokeasaurusrex/progress-bar-mode-refactor
branch
from
a2cb5e7
to
7fb5ed4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is more closely related to the utils module's progress bar code than to the api code, so we should move it there.
Ref #2008