Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

New Span Schema #1230

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

New Span Schema #1230

wants to merge 4 commits into from

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Apr 18, 2024

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 0:12am

Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this!

"endTimeUnixNano": "1544712661000000000",
"attributes": [
{
"key": "sentry.segment.id",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not 100% if sentry.segment_id would be better. I personally like the nesting but the Otel docs are ambiguous about it:

Namespaces can be nested. For example telemetry.sdk is a namespace inside top-level telemetry namespace and telemetry.sdk.name is an attribute inside telemetry.sdk namespace.

but

the fact that an entity is located within another entity is typically not a sufficient reason for forming nested namespaces. The purpose of a namespace is to avoid name clashes, not to indicate entity hierarchies.

https://opentelemetry.io/docs/specs/semconv/general/attribute-naming/

When in doubt, I would keep the ..

jjbayer added a commit to getsentry/relay that referenced this pull request Apr 22, 2024
To simplify conversion in the future, align attribute names in Otel's
span attributes with keys in Sentry's `span.data`. The old keys in
`span.data` remain as legacy alias.

See also getsentry/develop#1230 for the span
schema / attribute convention.

ref: #3278

---------

Co-authored-by: David Herberth <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants