Skip to content

Conversation

@eradman
Copy link
Collaborator

@eradman eradman commented Nov 25, 2025

What type of PR is this?

  • Feature

Description

Add lineShape option for Line and Area Charts

Linear
Spline
Horizontal-Vertical
Vertical-Horizontal

How is this tested?

  • Unit tests (pytest, jest)
  • Manually

Test Data

SELECT * 
FROM (VALUES
  ('2022-01-01', 45, 'B'),
  ('2022-02-01', 45, 'B'),
  ('2022-03-01', 65, 'B'),
  ('2022-04-01', 24, 'B'),
  ('2022-05-01', 55, 'B'),
  ('2022-05-01', 57, 'B'),
  ('2022-01-01', 58, 'A'),
  ('2022-02-01', 389, 'A'),
  ('2022-03-01', 537, 'A'),
  ('2022-04-01', 305, 'A'),
  ('2022-05-01', 360, 'A'),
  ('2022-05-01', 360, 'A')
) AS t(year, value, category);

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

line-shape-linear line-shape-spline line-shape-hv line-shape-vh

Linear
Spline
Horizontal-Vertical
Vertical-Horizontal
@yoshiokatsuneo
Copy link
Contributor

yoshiokatsuneo commented Nov 25, 2025

@eradman

Thank you !
It looks nice feature !
I confirmed that the feature works well.

Optionally, it might be also nice to support "hvh" and "vhv" shape type just to cover all types.
https://plotly.com/javascript/reference/#scatter-line-shape

@eradman eradman merged commit b5781a8 into getredash:master Nov 25, 2025
15 of 16 checks passed
@eradman
Copy link
Collaborator Author

eradman commented Nov 25, 2025

Thank you for the review @yoshiokatsuneo.

Optionally, it might be also nice to support "hvh" and "vhv" shape type just to cover all types

I was trying to limit the number of options, but yes, these would be easy to add

@eradman eradman deleted the line-shape branch November 25, 2025 16:44
eradman added a commit to eradman/redash that referenced this pull request Nov 25, 2025
Linear
Spline
Horizontal-Vertical
Vertical-Horizontal
eradman added a commit to StarfishStorage/redash that referenced this pull request Nov 25, 2025
Linear
Spline
Horizontal-Vertical
Vertical-Horizontal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants