Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Codecov token #7265

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Use Codecov token #7265

merged 1 commit into from
Dec 30, 2024

Conversation

lucydodo
Copy link
Member

What type of PR is this?

  • Other

Description

https://github.com/getredash/redash/actions/runs/12520572690/job/34926583828#step:9:37
In the previous Tests CI, the step to upload the coverage report to Codecov failed due to the token not being passed.

How is this tested?

  • Manually

Tested on personal fork: https://github.com/lucydodo/redash/actions/runs/12532752638

Related Tickets & Documents

Not applicable.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Not applicable.

@lucydodo lucydodo added the CI label Dec 29, 2024
@lucydodo lucydodo requested a review from Copilot December 29, 2024 05:48
@lucydodo lucydodo self-assigned this Dec 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@lucydodo
Copy link
Member Author

image
Separately, there’s also an issue in the 'frontend-e2e-tests' where it can’t find the coverage file.
I’ll investigate this further and create a PR for it.

Copy link
Collaborator

@eradman eradman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that we set CODECOV_TOKEN for the main project, so this should be good to go! https://github.com/getredash/redash/settings/secrets/actions

@eradman eradman enabled auto-merge (squash) December 30, 2024 20:41
@eradman eradman merged commit c08292d into getredash:master Dec 30, 2024
11 checks passed
@lucydodo
Copy link
Member Author

Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants