Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration to set default alert selector #7197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eradman
Copy link
Collaborator

@eradman eradman commented Oct 18, 2024

What type of PR is this?

  • Migration

Description

In commits fc1e1f7 and e44fcdb a new Selector option was added to alerts, which may be "first", "min" or "max". This migration sets the default to "first" for existing alerts.

How is this tested?

  • Manually
docker compose exec server ./manage.py db downgrade 9e8c841d1a30
docker compose exec server ./manage.py db upgrade

In commits fc1e1f7 and e44fcdb a new Selector option was added to
alerts, which may be "first", "min" or "max".  This migration sets the
default to "first" for existing alerts.
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.01%. Comparing base (c08292d) to head (360e1f2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7197   +/-   ##
=======================================
  Coverage   64.01%   64.01%           
=======================================
  Files         163      163           
  Lines       13410    13410           
  Branches     1905     1905           
=======================================
  Hits         8585     8585           
  Misses       4490     4490           
  Partials      335      335           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant