Fixed embedded queries

[denisov-vlad]

What type of PR is this?

• Refactor
• Feature
• Bug Fix
• New Query Runner (Data Source)
• New Alert Destination
• Other

Description

Fixed #6496
Also rewrote some methods to static and removed shadowing variable from outer scope.

How is this tested?

• Unit tests (pytest, jest)
• E2E Tests (Cypress)
• Manually
• N/A

Related Tickets & Documents

#6496

[codecov]

Codecov Report

Merging #6497 (277d77c) into master (c3c54f6) will increase coverage by 0.03%.
Report is 6 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6497      +/-   ##
==========================================
+ Coverage   61.07%   61.10%   +0.03%     
==========================================
  Files         157      158       +1     
  Lines       12834    12883      +49     
  Branches     1747     1753       +6     
==========================================
+ Hits         7838     7872      +34     
- Misses       4755     4765      +10     
- Partials      241      246       +5     

Files	Coverage Δ
redash/models/users.py	94.80% <100.00%> (+0.51%)	⬆️

... and 3 files with indirect coverage changes

[justinclift]

Is it feasible to add some kind of test, so the same bug doesn't happen again in future? 😄

[denisov-vlad]

@justinclift added tests for Users model

[justinclift]

@denisov-vlad Awesome, thanks heaps. 😄

[justinclift]

@guidopetri @konnectr @gaecoli @rpmcoding Any interest in reviewing this?

It looks like fairly straight forward Python. 😄

[justinclift]

Thanks @konnectr. 😄