feat: Add filter to the consumers list #52
+112
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an input field to filter consumers in the respective screen, a functionally everyone at my team greatly need :)
The filter is implemented as an anguler filter for the
ng-repeatonconsumerList, and it's filtering bydisplayTextto avoid making things complicated.Example
Before filter:
After filter:
Notes
Most of the code changes were done by Prettier. I've made sure that I pass lint, but if something goes against the coding style let me know and I'll redo the PR to only include the changes I made without any formatting.