Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106
What has been done to verify that this works as intended?
Updated CI jobs to test on all versions.
Why is this the best possible solution? Were any other approaches considered?
The ticket says up to 3.12, but 3.13 has been out for about 18 months and there as a forum post about it in Oct 2024. According to pypi, requests supports python 3.8-12, toml 3.3-9, pydantic 3.8-13.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Should enable more use cases without affecting existing python 3.12 use. There were some minor code / formatting changes but these should not affect users.
Do we need any specific form for testing your changes? If so, please attach one.
N/A
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Updated Readme doc with the new versions. As noted there the primary dev version is still 3.12 for now, and I updated the quoted Central version since that's the version on staging and the E2E tests in
test_client.py
pass against it.Before submitting this PR, please make sure you have:
tests
python -m unittest
and verified all tests passruff format pyodk tests
andruff check pyodk tests
to lint code