Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

106: Support Python 3.10 - 3.13 #108

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lindsay-stevens
Copy link
Contributor

Closes #106

What has been done to verify that this works as intended?

Updated CI jobs to test on all versions.

Why is this the best possible solution? Were any other approaches considered?

The ticket says up to 3.12, but 3.13 has been out for about 18 months and there as a forum post about it in Oct 2024. According to pypi, requests supports python 3.8-12, toml 3.3-9, pydantic 3.8-13.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Should enable more use cases without affecting existing python 3.12 use. There were some minor code / formatting changes but these should not affect users.

Do we need any specific form for testing your changes? If so, please attach one.

N/A

Does this change require updates to documentation? If so, please file an issue here and include the link below.

Updated Readme doc with the new versions. As noted there the primary dev version is still 3.12 for now, and I updated the quoted Central version since that's the version on staging and the E2E tests in test_client.py pass against it.

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests
  • run python -m unittest and verified all tests pass
  • run ruff format pyodk tests and ruff check pyodk tests to lint code
  • verified that any code or assets from external sources are properly credited in comments

Copy link
Member

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Good call on 3.13, we should probably start supporting it explicitly for pyxform as well.

@lognaturel lognaturel changed the title 106: Support Python 3.10 - 3.12 106: Support Python 3.10 - 3.13 Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.10 - 3.12
2 participants