-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Simplify opening web pages #6887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seadowg
wants to merge
13
commits into
getodk:master
Choose a base branch
from
seadowg:web-view
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+166
−349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only worked with Chrome and was really only properly being used on the About screen. It doesn't feel worth maintaining code with that level of complexity for that minimal benefit.
grzesiek2010
requested changes
Sep 17, 2025
web-page/src/main/java/org/odk/collect/webpage/ChromeTabsWebPageService.kt
Outdated
Show resolved
Hide resolved
web-page/src/main/java/org/odk/collect/webpage/ChromeTabsWebPageService.kt
Outdated
Show resolved
Hide resolved
web-page/src/main/java/org/odk/collect/webpage/ChromeTabsWebPageService.kt
Outdated
Show resolved
Hide resolved
web-page/src/test/java/org/odk/collect/webpage/ExternalWebPageHelperTest.java
Outdated
Show resolved
Hide resolved
web-page/src/main/java/org/odk/collect/webpage/ChromeTabsWebPageService.kt
Outdated
Show resolved
Hide resolved
web-page/src/main/java/org/odk/collect/webpage/ChromeTabsWebPageService.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #6886
Why is this the best possible solution? Were any other approaches considered?
This way of loading web pages was having problems with forum (Discourse) links as seen in #6879. My guess is that the double fallback it was there for (from Custom Tabs to external browser to
WebView
) is from a time when Custom Tabs were Chrome only (they were introduced almost 10 years ago to the day). That's no longer the case and most browsers on Android now support Custom Tabs, and it's very unlikely that a device would not have a browser installed.We'd also ended up using
WebViewActivity
directly in some parts of the app, but I think that's a mistake.Additionally, after refactoring how the web page preloading works, I realized that it was hardly being used, so I removed it. From the commit message:
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
There should be no noticeable changes other than for devices that don't have a browser installed - they will now see a Toast error when opening a web page from the app (like the links in About).
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passDateFormatsTest