Skip to content

Use nav graph in form hierarchy #6760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Jun 5, 2025

Work towards #5420

As much as possible, this prepares FormHierarchyFragment to be used in a single activity with a (not yet ready) FormEntryFragment in a nav graph.

Why is this the best possible solution? Were any other approaches considered?

I thought I'd already done this as part of an earlier refactor, but just realized it was missing. The next step here is to convert FormFillingActivity into a host activity a single destination nav graph (FormEntryFragment) and then we'll be able to integrate FormHierarchyFragment.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Navigating to and from the hierarchy is the area most affected here.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review July 8, 2025 12:42
@seadowg seadowg requested a review from grzesiek2010 July 8, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant