Use nav graph in form hierarchy #6760
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #5420
As much as possible, this prepares
FormHierarchyFragment
to be used in a single activity with a (not yet ready)FormEntryFragment
in a nav graph.Why is this the best possible solution? Were any other approaches considered?
I thought I'd already done this as part of an earlier refactor, but just realized it was missing. The next step here is to convert
FormFillingActivity
into a host activity a single destination nav graph (FormEntryFragment
) and then we'll be able to integrateFormHierarchyFragment
.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Navigating to and from the hierarchy is the area most affected here.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passDateFormatsTest