Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Generic Exception prefix for form submission errors #6526

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lognaturel
Copy link
Member

@lognaturel lognaturel commented Nov 21, 2024

This is a pet peeve of mine that I'm hoping will be an easy accept. I am annoyed every time I see "Error: Generic Exception: Error: " It looks like a mistake. I have never seen an error for which "Error: Generic Exception" added any information.

Before After
Screenshot_20241121_113101 Screenshot_20241121_113909

Why is this the best possible solution? Were any other approaches considered?

I considered only removing the Error: prefix but I really don't think Generic Exception adds anything either.

I didn't add any tests. I verified that there are no tests that expect that text currently.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

The biggest risk would be that there's an exception without any error message at all. But I think seeing the exception name, which the toString should give us, is way more useful than the static "Generic Exception" text.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
    there were no existing tests so it feels ok to leave as-is.
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
    I don't see any reason to run connected tests for this change.
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@lognaturel lognaturel changed the title Remove Generic Exception perfix for form submission Remove Generic Exception prefix for form submission Nov 21, 2024
@lognaturel lognaturel changed the title Remove Generic Exception prefix for form submission Remove Generic Exception prefix for form submission errors Nov 21, 2024
@grzesiek2010
Copy link
Member

I considered only removing the Error:

This indicates that the message already includes that prefix. Is this true for other messages as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants