Remove Generic Exception prefix for form submission errors #6526
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pet peeve of mine that I'm hoping will be an easy accept. I am annoyed every time I see "Error: Generic Exception: Error: " It looks like a mistake. I have never seen an error for which "Error: Generic Exception" added any information.
Why is this the best possible solution? Were any other approaches considered?
I considered only removing the
Error:
prefix but I really don't thinkGeneric Exception
adds anything either.I didn't add any tests. I verified that there are no tests that expect that text currently.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The biggest risk would be that there's an exception without any error message at all. But I think seeing the exception name, which the
toString
should give us, is way more useful than the static "Generic Exception" text.Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
there were no existing tests so it feels ok to leave as-is.
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passI don't see any reason to run connected tests for this change.
DateFormatsTest