Prevent resetting finalized forms that modify entities #6460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
requested changes
Oct 23, 2024
collect_app/src/androidTest/java/org/odk/collect/android/feature/settings/ResetProjectTest.kt
Show resolved
Hide resolved
seadowg
force-pushed
the
reset-entities
branch
from
9922894
to
72bdab1
Compare
grzesiek2010
approved these changes
Oct 24, 2024
6 tasks
|
Tested with Success Verified on device with Android 15 Verified cases:
|
|
Tested with Success Verified on device with Android 10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6435
Why is this the best possible solution? Were any other approaches considered?
Not a lot to discuss here! I just piggy backed on the existing helpers added to determine whether a form can safely be deleted and added a new use case for resetting entities now the logic is more complex than just deleting everything.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Just affects the saved form reset flow.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest