ci/build-push-image: fix nginx FRONTEND_BUILD_MODE error#2042
Merged
alxndrsn merged 6 commits intoJul 7, 2026
Conversation
added 5 commits
July 4, 2026 10:08
Fixes error seen on release: ``` > [linux/amd64 intermediate 4/5] RUN files/prebuild/write-version.sh: 0.073 files/prebuild/write-version.sh: line 26: FRONTEND_BUILD_MODE: unbound variable ```
This reverts commit 013ad82.
alxndrsn
changed the title
lognaturel
reviewed
Jul 6, 2026
| run: | | ||
| touch .env | ||
| echo "FRONTEND_VERSION=$( | ||
| docker compose config --format json | jq -r .services.nginx.build.args.FRONTEND_VERSION |
Member
There was a problem hiding this comment.
How about making this jq -er so the whole step fails if somehow the docker compose file or specific constant are missing?
Contributor
Author
There was a problem hiding this comment.
...but doesn't work out-of-the-box in this case.
I think the assignment would have to be extracted from the echo call.
lognaturel
approved these changes
Jul 6, 2026
lognaturel
left a comment
lognaturel
left a comment
Member
There was a problem hiding this comment.
Thank you! I think this can be merged now. But it won't give us tagged v2026.2.0 images, right? Can we somehow force this action version to run on the tagged commit? Or temporarily set the frontend version in Github variables and rerun the old action?
This was referenced Jul 7, 2026
alxndrsn
added a commit
that referenced
this pull request
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2043
What has been done to verify that this works as intended?
Ran it at: https://github.com/getodk/central/actions/runs/28703543011/job/85125477082
Still failing, but with a different error:
I think this error is correct - this build was not run on a release git tag, so it's probably correct that it doesn't have permission to upload docker images for a release docker tag.
Why is this the best possible solution? Were any other approaches considered?
Likely a better long-term solution is to change actions from
docker/build-push-actiontodocker/bake-action. However, this close to release it's prudent to keep changes minimal by not changing action. A ticket has been filed for changing action in the future at #2044.How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?
No impact.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.