client: replace submodule with specific release#1998
Merged
Conversation
alxndrsn
commented
Jun 16, 2026
alxndrsn
commented
Jun 16, 2026
added 9 commits
June 16, 2026 10:48
2 tasks
5 tasks
alxndrsn
commented
Jun 19, 2026
alxndrsn
commented
Jun 19, 2026
Member
|
Nothing blocking from me either, just a couple suggestions inline. |
alxndrsn
commented
Jun 22, 2026
alxndrsn
commented
Jun 22, 2026
alxndrsn
commented
Jun 22, 2026
alxndrsn
added a commit
to getodk/central-frontend
that referenced
this pull request
Jun 22, 2026
getodk/central#1998 changed the default approach to bundling central-frontend into the nginx docker image. This commit reverts building to the legacy ("classic") approach, allowing the local version to be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1996
What has been done to verify that this works as intended?
tested with dev builds(not relevant)Why is this the best possible solution? Were any other approaches considered?
client/directoryHow does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
client/central-frontendcodeclient/central-frontendcode, although they will need to set a new var indocker-compose.ymlwhen updatingDoes this change require updates to documentation? If so, please file an issue here and include the link below.
Yes - deployers who have made edits to
clientwill now need to manage those separately (if they weren't already), e.g.:Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)