Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move styles from SubmissionComment to MarkdownTextarea #776

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matthew-white
Copy link
Member

@matthew-white matthew-white commented Apr 10, 2023

I was randomly looking at SubmissionComment and noticed that it sets styles on #submission-comment-actions. However, it looks like there isn't a #submission-comment-actions element anymore: I think that element was moved into MarkdownTextarea as part of #483 more than a year ago. This PR moves the styles from SubmissionComment into MarkdownTextarea, though given that they haven't been in use for a while, we'd probably also be fine removing them.

The styles do two things:

  • Adds 5px of margin-top.
  • Adds an animation on margin-bottom.

I've recorded the current behavior (without these styes) and the behavior with these styles. I slowed down the animation in the recording so that it's easier to see.

Current behavior (without styles):

Screen.Recording.2023-04-10.at.2.38.18.PM.mov


With styles:

Screen.Recording.2023-04-10.at.2.33.36.PM.mov


@ktuite, do you remember these styles at all? Do you know whether we intended to remove them?

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@matthew-white matthew-white marked this pull request as ready for review February 15, 2025 00:37
@matthew-white matthew-white requested a review from ktuite February 15, 2025 00:38
Copy link
Member Author

@matthew-white matthew-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes from interactive review

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not add the animation styles here; let's just remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants