Skip to content

[Grow-166] TagManagerWrapper without doing the GTM setup automatically #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2019

Conversation

wilfernandesjr
Copy link
Contributor

CHANGELOG 📝

  • The tagManagerWrapper init method stop to append script and noscript tags into html's head. The private methods _appendAsyncScript and _appendNoScriptFallBack have been removed, once they aren't necessary anymore;
  • The init method concatenates the dataLayer property (initialized on constructor, by a parameter value) with the global dataLayer object defined on GTM setup (tagManagerDataLayer variable);
  • By this new version, you should do the GTM setup manually, following the official instructions. Don't forget to replace the global variable dataLayer by tagManagerDataLayer

@wilfernandesjr wilfernandesjr changed the title Grow 166 tag manager [Grow-166] TagManagerWrapper without doing the setup of GTM automatically Nov 28, 2019
@wilfernandesjr wilfernandesjr changed the title [Grow-166] TagManagerWrapper without doing the setup of GTM automatically [Grow-166] TagManagerWrapper without doing the GTM setup automatically Nov 28, 2019
Copy link

@yvessacurae yvessacurae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

@MarcelaBarella MarcelaBarella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪 🍪 🍪 se joga mlk

@wilfernandesjr wilfernandesjr merged commit feb3da0 into master Dec 2, 2019
@wilfernandesjr wilfernandesjr deleted the GROW-166_tagManager branch December 2, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants