Skip to content

Conversation

@bpandola
Copy link
Collaborator

  • model typing and attribute name fix-ups
  • test assertions added for better coverage
  • conditional response field helper methods moved from ECS backend to BaseResponse for use with IncludePublicKey parameter
  • XML templates deleted

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.03%. Comparing base (687142f) to head (2a0f060).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9465   +/-   ##
=======================================
  Coverage   93.02%   93.03%           
=======================================
  Files        1293     1293           
  Lines      116237   116252   +15     
=======================================
+ Hits       108134   108151   +17     
+ Misses       8103     8101    -2     
Flag Coverage Δ
servertests 28.82% <33.33%> (+<0.01%) ⬆️
unittests 93.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bpandola bpandola added this to the 5.1.17 milestone Nov 13, 2025
@bpandola bpandola merged commit a2ce4bd into getmoto:master Nov 13, 2025
73 checks passed
@bpandola bpandola deleted the serialization/ec2/key-pairs branch November 13, 2025 05:21
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup @bpandola! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants