-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
AutoScaling: Mixed instance autoscaling groups #9444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutoScaling: Mixed instance autoscaling groups #9444
Conversation
|
This PR adds more extensive calculations for MixedInstanceTypes for auto scaling groups, which are closer to what AWS does internally.
Limitations: The function currently expects a "prioritized" strategy for the OnDemandAllocationStrategy. Adding more strategies would have been out of scope, so this was left as is. |
|
@viren-nadkarni please start the workflows, review the changes and if ready mark as ready for review please :) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9444 +/- ##
==========================================
+ Coverage 93.02% 93.04% +0.01%
==========================================
Files 1292 1295 +3
Lines 116184 116441 +257
==========================================
+ Hits 108083 108341 +258
+ Misses 8101 8100 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bblommers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for adding this feature to Moto @baermat and @viren-nadkarni!
Please see the comment below for PR description