Skip to content

Remove Kirby\Blueprint package #7119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

Remove Kirby\Blueprint package #7119

merged 1 commit into from
Apr 7, 2025

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Apr 4, 2025 •
edited by bastianallgeier
Loading

Description

Summary of changes

  • Removed Kirby\Blueprint package
  • Adapted Kirby\Option classes to work independently

Changelog

Breaking changes

  • All Kirby\Blueprint classes have been removed

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added this to the 5.0.0-rc.1 milestone Apr 4, 2025
@distantnative distantnative self-assigned this Apr 4, 2025
@distantnative distantnative marked this pull request as ready for review April 4, 2025 16:39
@distantnative distantnative requested a review from a team April 4, 2025 16:39
bastianallgeier
bastianallgeier approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The amount of removed code is quite convincing :)

@bastianallgeier bastianallgeier merged commit 04b5f01 into v5/develop Apr 7, 2025
12 checks passed
@bastianallgeier bastianallgeier deleted the v5/refactor/remove-blueprint-package branch April 7, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
None yet
Milestone
5.0.0-beta.6
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier