Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mutiple terminals and fix focus on terminal when opened #351

Closed
wants to merge 5 commits into from

Conversation

elanzini
Copy link
Contributor

@elanzini elanzini commented Mar 28, 2023

Fixes #350

I am seeing a warning in console due to the version of xterm.

xterm.js?a212:4810 Canvas2D: Multiple readback operations using getImageData are faster with the willReadFrequently attribute set to true.

and likely related to these errors that I am seeing in the console:
[42247:0328/221209.783899:ERROR:CONSOLE(6)] "console.assert", source: devtools://devtools/bundled/panels/console/console.js (6)

I tried to update the package to latest but there is some incompatibility with xterm-addon-fit.
Didn't spend much time looking into it but didn't seem to cause issues with the functionality.

Demo:

Screen.Recording.2023-03-28.at.21.51.07.mov

@elanzini elanzini force-pushed the support-mutiple-terminals branch 4 times, most recently from 05bc3e5 to cd908aa Compare April 1, 2023 08:54
@truell20
Copy link
Contributor

truell20 commented May 1, 2023

thanks for working on this! believe this should be fixed in the newest vscode-based version of Cursor

@truell20 truell20 closed this May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple terminals and focus on open
2 participants