Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Vue.js syntax support #335

Merged
merged 8 commits into from Apr 6, 2023
Merged

Conversation

boxizen
Copy link
Contributor

@boxizen boxizen commented Mar 28, 2023

closes #266

I have added the vuejs language pack on codemirror.
For details, check this PR.

Just need to update the next version to take effect, the support of VueJS is as follows.

image

@boxizen boxizen changed the title feat: update codemirror & support VueJs Add Vue.js syntax support Mar 28, 2023
@boxizen boxizen changed the title Add Vue.js syntax support Add: Vue.js syntax support Mar 28, 2023
@fischeversenker
Copy link

Note from a random stranger:
As far as I can tell, the only relevant change in this PR is the version bump in the package.json and the corresponding changes in the package-lock.json. Everything else is just noise that makes this PR a lot harder to review. If I was a maintainer, I would ask you to remove the unrelated changes.
If you agree with me, you might want to revert these changes to help fellow contributors, @boxizen 🙏

@boxizen
Copy link
Contributor Author

boxizen commented Mar 28, 2023

Note from a random stranger: As far as I can tell, the only relevant change in this PR is the version bump in the package.json and the corresponding changes in the package-lock.json. Everything else is just noise that makes this PR a lot harder to review. If I was a maintainer, I would ask you to remove the unrelated changes. If you agree with me, you might want to revert these changes to help fellow contributors, @boxizen 🙏

You're right, but the author added a code formatting check last night, and if I don't prettier the rest of the code, it won't pass the check

@fischeversenker
Copy link

Thanks for the feedback. I now found #271 and saw that you are already involved there.
Sorry for interfering 🙈
Keep on being awesome 🙌

@truell20 truell20 merged commit d8f7fdf into getcursor:main Apr 6, 2023
3 checks passed
@truell20
Copy link
Contributor

truell20 commented Apr 6, 2023

thank you for this!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vuejs support?
3 participants