Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the silent conversion approach fix #66 #69

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Conversation

chainsawriot
Copy link
Collaborator

No description provided.

@schochastics
Copy link
Member

ah now I get it. I actually did not know that you can supply default argument values in c++ too.

@chainsawriot
Copy link
Collaborator Author

header hygiene, I wanted to say.

@chainsawriot chainsawriot marked this pull request as ready for review January 31, 2024 19:22
@schochastics
Copy link
Member

I am happy with this if you want to merge it

@schochastics
Copy link
Member

maybe increment version

@chainsawriot chainsawriot merged commit 43284da into main Jan 31, 2024
8 checks passed
@chainsawriot chainsawriot deleted the silent_conv branch January 31, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants