added set functions (fix #15)

[schochastics]

No description provided.

[schochastics]

Not sure what is going on with username and password

url <- "https://user_1:[email protected]:8080/dir/../api?q=1#frag"
adaR::ada_set_password(url, "hunter2")
#> [1] "https://user_1:hunter2"
adaR::ada_set_username(url, "user_2")
#> [1] "https://user_2"

[schochastics]

@chainsawriot there are two types of set functions: bool/void, so I defined two Rcpp_ada_set_ main functions. Do you think one can unify them?

[chainsawriot]

Yes, it can be unified by creating a template. Will give it a try.

[chainsawriot]

template <typename T>
CharacterVector Rcpp_ada_set(
    const CharacterVector& url_vec,
    std::function<T(ada_url, const char*, size_t)> func,
    const CharacterVector& subst, bool decode) {
  unsigned int n = url_vec.length();
  CharacterVector out(n);
  for (int i = 0; i < url_vec.length(); i++) {
    String s = url_vec[i];
    String s2 = subst[i];
    std::string_view input(s.get_cstring());
    std::string_view replace(s2.get_cstring());
    ada_url url = ada_parse(input.data(), input.length());
    if (!ada_is_valid(url)) {
      out[i] = NA_STRING;
    } else {
      func(url, replace.data(), replace.length());
      out[i] = charsub(ada_get_href(url));
    }
    ada_free(url);
  }
  if (decode) {
    out = Rcpp_url_decode2(out);
  }
  return (out);
}

// [[Rcpp::export]]
CharacterVector Rcpp_ada_set_href(const CharacterVector& url_vec,
                                  const CharacterVector& subst, bool decode) {
  return Rcpp_ada_set<bool>(url_vec, &ada_set_href, subst, decode);
}

// [[Rcpp::export]]
CharacterVector Rcpp_ada_set_hash(const CharacterVector& url_vec,
                                  const CharacterVector& subst, bool decode) {
  return Rcpp_ada_set<void>(url_vec, &ada_set_hash, subst, decode);
}

[schochastics]

thanks, will integrate that later tonight

[schochastics]

@chainsawriot does the trick, thank you again. Finally understood the purpose of templates