Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #26 #28

Merged
merged 5 commits into from
Sep 25, 2023
Merged

Fix #26 #28

merged 5 commits into from
Sep 25, 2023

Conversation

chainsawriot
Copy link
Collaborator

No description provided.

so that I won't mess up the style
`get_*` can has the same treatment; but for later
Do the calculation in C++ with `std::strlen`
@chainsawriot chainsawriot marked this pull request as ready for review September 25, 2023 07:30
@schochastics
Copy link
Member

thanks!

@schochastics schochastics merged commit 346f86c into gesistsa:main Sep 25, 2023
6 checks passed
@chainsawriot
Copy link
Collaborator Author

@schochastics More tests will be added later for the PR #3.

Suggestion:

  1. Do you want to consolidate the documentation of all ada_has_* in one documentation.
  2. I found that utf8::as_utf8 is probably not needed on modern enough R. It can cut the running time by ~10%. But you would at least need to set the R requirement to 4.2 (for those using Windows).

@schochastics
Copy link
Member

@chainsawriot

  1. yes. If you fix the NULL thing, do you mind doing that in the same PR?
  2. Will think about that but I think it is a good idea. I also would like to get rid of the vapply for the length which is a runtime killer

@chainsawriot
Copy link
Collaborator Author

@schochastics Good, will do 1.

  1. The length thing is partially fixed by calculating the char* length in C++.

@schochastics
Copy link
Member

schochastics commented Sep 25, 2023

@chainsawriot yes I realized that too just now.

chainsawriot added a commit to chainsawriot/adaR that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants