Skip to content

Commit

Permalink
fix submission issues
Browse files Browse the repository at this point in the history
  • Loading branch information
schochastics committed Sep 29, 2023
1 parent 6f5fb4e commit fa2fcf9
Show file tree
Hide file tree
Showing 7 changed files with 30 additions and 3 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@
^docs$
^pkgdown$
^cran-comments\.md$
^CRAN-SUBMISSION$
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Package: adaR
Title: A Fast WHATWG Compliant URL Parser
Title: A Fast 'WHATWG' Compliant URL Parser
Version: 0.2.0
Authors@R:
c(person("David", "Schoch", , "[email protected]", role = c("aut", "cre"),
Expand All @@ -9,7 +9,7 @@ Authors@R:
person("Yagiz", "Nizipli", role = c("ctb", "cph"),comment = "author of ada-url : <https://github.com/ada-url/ada>"),
person("Daniel", "Lemire", role = c("ctb", "cph"),comment = "author of ada-url : <https://github.com/ada-url/ada>")
)
Description: A wrapper for ada-url, a WHATWG-compliant and fast URL parser written in modern C++. Also contains auxiliary functions such as a public suffix extractor.
Description: A wrapper for 'ada-url', a 'WHATWG' compliant and fast URL parser written in modern 'C++'. Also contains auxiliary functions such as a public suffix extractor.
URL: https://schochastics.github.io/adaR/, https://github.com/schochastics/adaR
BugReports: https://github.com/schochastics/adaR/issues
License: MIT + file LICENSE
Expand Down
1 change: 1 addition & 0 deletions R/parse.R
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ ada_url_parse <- function(url, decode = TRUE) {
#' Similar to [utils::URLdecode]
#'
#' @param url a character vector
#' @return precent decoded URLs as character vector
#' @export
#' @examples
#' url_decode2("Hello%20World")
Expand Down
1 change: 1 addition & 0 deletions R/psl.R
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#'
#' @param domains character. vector of domains or hostnames
#' @export
#' @return public suffixes of domains as character vector
#' @examples
#' public_suffix("http://example.com")
#'
Expand Down
20 changes: 19 additions & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,22 @@
## Initial Submission
## Resubmission of initial submission

Please always write package names, software names and API (application
programming interface) names in single quotes in title and description.
e.g: --> 'WHATWG', 'C++', 'ada-url'
Please note that package names are case sensitive.

-> fixed

If there are references describing the methods in your package, please
add these in the description field of your DESCRIPTION file in the form

-> there are no official or citable references describing the method

Missing Rd-tags:
public_suffix.Rd: \value
url_decode2.Rd: \value

-> fixed

# Test environments
* ubuntu 22.04, R 4.3.1
Expand Down
3 changes: 3 additions & 0 deletions man/public_suffix.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions man/url_decode2.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit fa2fcf9

Please sign in to comment.