Merge pull request #24 from chainsawriot/fix_has_creds

Fix `ada_has_credentials` vectorization
gesistsa · Sep 24, 2023 · 8d7b042 · 8d7b042
2 parents 625ef06 + f955b2d
commit 8d7b042
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/R/has.R b/R/has.R
@@ -6,7 +6,7 @@
 #' @export
 ada_has_credentials <- function(url) {
     url <- utf8::as_utf8(url)
-    vapply(url, function(x) vapply(url, function(x) Rcpp_ada_has_credentials(x, nchar(x, type = "bytes")), logical(1)), logical(1))
+    vapply(url, function(x) Rcpp_ada_has_credentials(x, nchar(x, type = "bytes")), logical(1))
 }
 
 #' Check if URL has an empty hostname

diff --git a/tests/testthat/test-has.R b/tests/testthat/test-has.R
@@ -9,3 +9,7 @@ test_that("all has functions work", {
   expect_true(ada_has_port(url))
   expect_true(ada_has_search(url))
 })
+
+test_that("ada_has_credentials is vectorized ref #3", {
+  expect_error(res <- ada_has_credentials(c("https://admin:[email protected]/basic_auth", "https://www.google.com")), NA)  
+})