Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to introduction notebook #34

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

larsbonczek
Copy link
Contributor

@larsbonczek larsbonczek commented Oct 11, 2022

Binder build of this repository fails with the following output:

Waiting for build to start...
Picked Git content provider.
Cloning into '/tmp/repo2dockerjuuhwwu_'...
HEAD is now at 9936fc2 Merge pull request #26 from gesiscss/ctr26
Using DockerBuildPack builder
Step 1/9 : FROM jupyter/base-notebook:hub-1.4.2
 ---> 3059097d7b03
Step 2/9 : COPY intro_to_persistent_binderhub.ipynb ${HOME}/intro_to_persistent_binderhub.ipynb
COPY failed: file not found in build context or excluded by .dockerignore: stat intro_to_persistent_binderhub.ipynb: file does not exist

I fixed the error by changing

COPY intro_to_persistent_binderhub.ipynb ${HOME}/intro_to_persistent_binderhub.ipynb

to

COPY .binder/intro_to_persistent_binderhub.ipynb ${HOME}/intro_to_persistent_binderhub.ipynb

Fixes #29

@arnim
Copy link
Member

arnim commented Oct 11, 2022

@MridulS can we merge this?

@arnim arnim merged commit cbbe8b2 into gesiscss:master Oct 11, 2022
@MridulS
Copy link
Contributor

MridulS commented Oct 11, 2022

Yeah :)

Thanks @larsbonczek !

@larsbonczek
Copy link
Contributor Author

Wow, that was quick! Thanks for merging :)

@arnim
Copy link
Member

arnim commented Oct 11, 2022

Thanks for the PR @larsbonczek

We are currently in a project with 2I2C (CC @damianavila) to make this functionality more widely accessible. We will give an update on how to migrate as soon as we know more.

@arnim
Copy link
Member

arnim commented Oct 11, 2022

tracking issue for the successor project with 2I2C 2i2c-org/infrastructure/issues/1382

@larsbonczek
Copy link
Contributor Author

Thanks for the link @arnim, I've actually already been following that issue. Looking forward to your update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default image build failure
3 participants