Fix #10295 fixed measure tool rendering in map #10331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* avoiding being covered by search tool and widgets * both 2d and 3d
MV88
added
bug
Internal
BackportNeeded
web/client/plugins/Measure.jsx
Outdated
| : <Measure {...props} />; | ||
| )(({coordsAeronauticalEnabled, ...props}) => { | ||
| return ( | ||
| <div className={`measure-container${coordsAeronauticalEnabled ? " bottom-offset" : ""}`}> |
There was a problem hiding this comment.
Probably it's better top-offset from the point of view of the measure toolbar.
Another possibility is to use directly inline style
allyoucanmap
approved these changes
May 20, 2024
|
@ElenaGallo please test on dev and let us know if we can backport, thanks |
|
Test passed, @MV88 please backport to 2024.01.xx. Thanks |
MV88
added a commit
to MV88/MapStore2
that referenced
this pull request
May 21, 2024
MV88
added a commit
that referenced
this pull request
May 21, 2024
ElenaGallo
removed
the
BackportNeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Fix #10295
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information