Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic OIDC provider support #10152

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Conversation

offtherailz
Copy link
Member

@offtherailz offtherailz commented Apr 3, 2024

In draft waiting for fixes on geostore side, and to update doc in this PR too:

Description

This PR configures the integration of a generic OIDC provider (provided by geosolutions-it/geostore#330 ) in MapStore, documenting it.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#10151

What is the new behavior?

#10151 integrated (logout still to be impelmented on GeoStore, so not closing it).

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@offtherailz offtherailz added this to the 2024.02.00 milestone Apr 3, 2024
@offtherailz offtherailz self-assigned this Apr 3, 2024
@tdipisa tdipisa self-requested a review April 3, 2024 16:14
@tdipisa tdipisa modified the milestones: 2024.02.00, 2024.01.01 Apr 3, 2024
@tdipisa tdipisa linked an issue Apr 3, 2024 that may be closed by this pull request
4 tasks
@offtherailz offtherailz added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Apr 4, 2024
@offtherailz offtherailz marked this pull request as draft April 8, 2024 10:37
@offtherailz offtherailz marked this pull request as ready for review May 15, 2024 16:30
@offtherailz
Copy link
Member Author

@tdipisa this is ready to review now.
This should be tested with Azure @afabiani

Copy link
Member

@tdipisa tdipisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@offtherailz as discussed, I would like to add an entry point section in the documentation to provide an overall picture of available capabilities of the current OpenID support in MS across different OpenID clients / configuration methodologies we have (using old clients and the new one) such as:

  • Available clients and what they can do
  • Which limits they have
  • How them can be combined to provide multiple auths
  • Future steps also in term of deprecation of the old clients

I would like to provide only a brief preliminary indication of the above to allow readers to learn the details in the relevant sections of the documentation.

@offtherailz offtherailz requested a review from tdipisa May 17, 2024 08:38
docs/developer-guide/integrations/users/openId.md Outdated Show resolved Hide resolved
docs/developer-guide/integrations/users/openId.md Outdated Show resolved Hide resolved
docs/developer-guide/integrations/users/openId.md Outdated Show resolved Hide resolved
docs/developer-guide/integrations/users/openId.md Outdated Show resolved Hide resolved
docs/developer-guide/integrations/users/openId.md Outdated Show resolved Hide resolved
docs/developer-guide/integrations/users/openId.md Outdated Show resolved Hide resolved
docs/developer-guide/integrations/users/openId.md Outdated Show resolved Hide resolved
docs/developer-guide/integrations/users/openId.md Outdated Show resolved Hide resolved
docs/developer-guide/mapstore-migration-guide.md Outdated Show resolved Hide resolved
@tdipisa tdipisa modified the milestones: 2024.01.01, 2024.01.02 May 29, 2024
@offtherailz offtherailz requested a review from tdipisa June 5, 2024 09:56
@offtherailz
Copy link
Member Author

This can be merged for me. @tdipisaThe release is confirmed ? review and merge when you want.
If the release is confirmed, I'll proceed with backport.

@tdipisa tdipisa merged commit 3c550c8 into geosolutions-it:master Jun 11, 2024
6 checks passed
@tdipisa
Copy link
Member

tdipisa commented Jun 11, 2024

@offtherailz please test with Azure before backporting it. The milestone is confirmed, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C206-DEUTSCHE_BAHN-2024-SUPPORT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenID generic provider support
2 participants