Fix GEOS-Chem 14.5.0 build in CESM by excluding hard dependencies on HEMCO #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HEMCO In the CESM model, emissions through HEMCO are provided to GEOS-Chem through the physics buffer and not through the HEMCO subroutine calls. A side-effect of this implementation is that HEMCO versions and GEOS-Chem versions in CESM can be decoupled, and thus hard-dependencies on HEMCO data structures should not apply. In this particular case, additional ExtState fields in HEMCO are causing CESM build failures in the latest GEOS-Chem version. Most (but not all) subroutines in hco_interface_gc_mod.F90 are unused in CESM and are now blocked off from MODEL_CESM to avoid this hard dependency. Signed-off-by: Haipeng Lin <[email protected]>
yantosca
added
category: Interface to External Model
yantosca
requested changes
Oct 31, 2024
|
Thanks @yantosca, changelog updated! |
lizziel
reviewed
Nov 1, 2024
CHANGELOG.md
Outdated
| @@ -40,6 +40,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| - Removed EDGAR8_CH4_AWB emissions from CH4 and carbon simulations to avoid double counting with GFED | |||
| - Fixed formatting error in `.github/workflows/stale.yml` that caused the Mark Stale Issues action not to run | |||
| - Fixed emissions in GCHP carbon ExtData.rc so that data in molecules/cm2/s are converted to kg/m2/s | |||
| - Excluded HEMCO interface and ExtState fields from `MODEL_CESM` in `hco_interface_gc_mod.F90` for compatibility with CESM, which runs HEMCO separately | |||
There was a problem hiding this comment.
Could you move this to Changed? Fixed implies there was a bug in a previous version which in this case I don't think there was.
There was a problem hiding this comment.
Yes, done! Thank you
lizziel
approved these changes
Nov 1, 2024
msulprizio
changed the base branch from
dev/14.5.0
to
dev/no-diff-to-benchmark
|
Note that I have changed the base branch to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Haipeng Lin
Institution: Harvard Univ.
Describe the update
In the CESM model, emissions through HEMCO are provided to GEOS-Chem through the physics buffer and not through the HEMCO subroutine calls. A side-effect of this implementation is that HEMCO versions and GEOS-Chem versions in CESM can be decoupled, and thus hard-dependencies on HEMCO data structures should not apply.
In this particular case, additional ExtState fields in HEMCO are causing CESM build failures in the latest GEOS-Chem version. Most (but not all) subroutines in hco_interface_gc_mod.F90 are unused in CESM and are now blocked off from MODEL_CESM to avoid this hard dependency.
Note:
HCOI_GC_WriteDiagnwas rearranged in the module but otherwise unchanged, in order to use one#if !defined( MODEL_CESM )Expected changes
None
Reference(s)
N/A
Related Github Issue
Building CESM with latest GEOS-Chem tag
14.5.0-rc.0