-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CEDS 0.1 x 0.1 degree emissions #2171
base: dev/14.5.0
Are you sure you want to change the base?
Conversation
run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.fullchem
Outdated
Show resolved
Hide resolved
@1Dandan @Ruijun-Dang: Just wanted to tag #1745 (comment) on this PR. Will await your feedback before proceeding. |
Hi @yantosca @msulprizio, the seasonality problem as mentioned in #1745 should be fixed in the new version of v2024-06. File names remain the same as those in v2023-04, and thus all v2023-04 can be replaced by v2024-06 for HEMCO_Config.rc and ExtData.rc templates. Let me know if you want other inputs from me. |
run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.fullchem run/GCHP/HEMCO_Config.rc.templates/HEMCO_Config.rc.fullchem - Added entries for CEDS 0.1 x 0.1 degree emissions. NOTE: ExtData.rc.fullchem will be updated later. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.fullchem - CEDS01 comment update "1750-2019" -> "1980-2019" - Also updated header comments run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.aerosol run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.carbon run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.TransportTracers run/GCHP/HEMCO_Config.rc.templates/HEMCO_Config.rc.carbon run/GCHP/HEMCO_Config.rc.templates/HEMCO_Config.rc.TransportTracers run/GCHP/HEMCO_Config.rc.templates/HEMCO_Config.rc.fullchem run/GCHP/ExtData.rc.templates/ExtData.rc.carbon run/GCHP/ExtData.rc.templates/ExtData.rc.fullchem run/GCHP/ExtData.rc.templates/ExtData.rc.TransportTracers - Added entries for CEDS_01x01 as the default - Now make CEDSv2 an option Signed-off-by: Bob Yantosca <[email protected]>
run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.fullchem run/GCHP/HEMCO_Config.rc.templates/HEMCO_Config.rc.fullchem - For container "CEDS01_TOLU_WST", added scale factor=26, cat=1, hier=5. This had been omitted due to a cut-n-paste error. Signed-off-by: Bob Yantosca <[email protected]>
run/GCHP/ExtData.rc.TransportTracers - Fixed typo: "shoul'd" -> "should Signed-off-by: Bob Yantosca <[email protected]>
This rebase merge brings PR #2171 (CEDS 0.1 x 0.1 emissions) atop PR #2352 (ALK4 & R4N2 chemistry updates) Signed-off-by: Bob Yantosca <[email protected]>
5b9946e
to
34f8f67
Compare
Hi @yantosca, I noticed that the CEDS 0.1 version is still |
Thanks @1Dandan, yes I just rebased the existing code atop of dev/14.5.0. I'll push another commit to update the directory paths. |
Updated the following configuration files to read CEDS 0.1 x 0.1 degree emissions data from the HEMCO/CEDS/v2024-06 folder: run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.aerosol run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.carbon run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.fullchem run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.tagCO run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.TransportTracers run/GCHP/ExtData.rc.templates/ExtData.rc.carbon run/GCHP/ExtData.rc.templates/ExtData.rc.fullchem run/GCHP/ExtData.rc.templates/ExtData.rc.TransportTracers Also updated the CHANGELOG.md accordingly. Signed-off-by: Bob Yantosca <[email protected]>
CHANGELOG.md - Edited previous comment to note that the CEDS data are in v2024-06 Signed-off-by: Bob Yantosca <[email protected]>
run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.fullchem - Fixed mismatching brackets for CEDS_01x01_SHIP for NO emissions Signed-off-by: Bob Yantosca <[email protected]>
All GEOS-Chem integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #0c22a3a GEOS-Chem submod update: PR #2352 post-merge fix (rebuild KPP files)
GEOS-Chem #769698837 Fix mismatching brackets in HEMCO_Config.rc template
HEMCO #e68ebae HEMCO 3.9.2 release
Using 24 OpenMP threads
Number of execution tests: 28
Submitted as SLURM job: 43586737
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
run/GCHP/ExtData.rc.templates/ExtData.rc.carbon - Change climatology data entries from e.g "2009 Y" to "Y Y F2009-..." - Remove slug left over from Git merge Signed-off-by: Bob Yantosca <[email protected]>
Hi @yantosca and @1Dandan, CEDS also identifies their versions with the release date (https://github.com/JGCRI/CEDS/releases) and users can confuse that with the folder names in our CEDS data directory. For example, CEDS had a new version called v_2024_04_01, but I think our folder v2024-06 has CEDS version v_2021_4_21 data. Could we display the CEDS version prominently to avoid any confusion? Thanks. |
Thanks @viral211 for the suggestion. I agree that it is confusing as our processed version may conflict with the releasing date of the original version. I add a line in the README of |
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Confirm you have reviewed the following documentation
Describe the update
This is the companion PR to #1745.
Expected changes
As described in #1745
Related Github Issue(s)
Tagging @msulprizio