Skip to content

Return Option<Self> in fallible constructors #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kylebarron merged 1 commit into from
Apr 15, 2025
Merged

Return Option<Self> in fallible constructors #141

kylebarron merged 1 commit into from
Apr 15, 2025

Conversation

@kylebarron
Copy link
Member

@kylebarron kylebarron commented Apr 15, 2025 •
edited
Loading

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.
  • I ran cargo fmt

Ref #135 (comment)

@kylebarron kylebarron requested a review from michaelkirk April 15, 2025 21:18
michaelkirk
michaelkirk approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kylebarron kylebarron merged commit 03d85b1 into main Apr 15, 2025
1 check passed
@kylebarron kylebarron deleted the kyle/consturctors-option branch April 15, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelkirk michaelkirk michaelkirk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kylebarron @michaelkirk