Skip to content
This repository has been archived by the owner on Apr 2, 2022. It is now read-only.

Bump approx and include_dir #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump approx and include_dir #9

wants to merge 2 commits into from

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Jan 20, 2022

No description provided.

@lnicola lnicola changed the title Bump approx Bump approx and include_dir Jan 20, 2022
@lnicola
Copy link
Member Author

lnicola commented Jan 20, 2022

The autocfg dependency comes from num-traits, so this doesn't actually bring us anything 😞.

@michaelkirk
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jan 20, 2022
@bors
Try #9:
135fe97
@michaelkirk
Copy link
Member

The autocfg dependency comes from num-traits, so this doesn't actually bring us anything 😞.

I'm not sure what the goal of this PR was in the first place - something more than just keeping our deps updated?

I'm assuming we'll need some kind of corresponding update in geo/geo-geotypes?

@bors
Copy link
Contributor

bors bot commented Jan 20, 2022

try

Build failed:

@lnicola
Copy link
Member Author

lnicola commented Jan 26, 2022

I wonder if we can read the files at run-time from under CARGO_MANIFEST_DIR.

@michaelkirk
Copy link
Member

I wonder if we can read the files at run-time from under CARGO_MANIFEST_DIR.

Fine with me!

nyurik
nyurik reviewed Mar 15, 2022
View reviewed changes
Cargo.toml
@@ -7,9 +7,9 @@ edition = "2018"
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
approx = "0.4.0"
approx = "0.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be patched version?

Suggested change
approx = "0.5"
approx = "0.5.0"

nyurik
nyurik reviewed Mar 15, 2022
View reviewed changes
Cargo.toml
geo = "*"
include_dir = { version = "0.6", features = ["search"] }
include_dir = { version = "0.7", features = ["glob"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
include_dir = { version = "0.7", features = ["glob"] }
include_dir = { version = "0.7.0", features = ["glob"] }

@nyurik
Copy link
Member

nyurik commented Mar 15, 2022

I wonder if we can read the files at run-time from under CARGO_MANIFEST_DIR.

You might be interested in georust/geo#764

This was referenced Mar 22, 2022
Closed
Draft
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nyurik nyurik nyurik left review comments

@michaelkirk michaelkirk Awaiting requested review from michaelkirk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lnicola @michaelkirk @nyurik