-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement geo_traits
for geojson
types.
#245
Open
frewsxcv
wants to merge
11
commits into
main
Choose a base branch
from
geo-traits-impl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,053
−0
Open
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fca637e
Implement `geo_traits` for `geojson` types.
frewsxcv e6461ef
unused imports
frewsxcv 6f5b520
unneeded doc(hidden)
frewsxcv 403a089
dry
frewsxcv 0c503b6
comment
frewsxcv b74e52b
make optional; use stable version
frewsxcv d57de45
implement for featurecollection, feature, and geojson
frewsxcv 466a5cb
basic implementation test
frewsxcv 7bd2f75
format
frewsxcv 765e37a
implement for &GeoJson
frewsxcv 40bec4b
remove methods with default impls
frewsxcv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
use super::PointType; | ||
use geo_traits::Dimensions; | ||
|
||
impl geo_traits::CoordTrait for PointType { | ||
type T = f64; | ||
|
||
fn dim(&self) -> Dimensions { | ||
match self.0.len() { | ||
0 | 1 => panic!("Position must have at least 2 dimensions"), | ||
2 => Dimensions::Xy, | ||
3 => Dimensions::Xyz, | ||
_ => Dimensions::Unknown(self.0.len()), | ||
} | ||
} | ||
|
||
fn x(&self) -> Self::T { | ||
self.0[0] | ||
} | ||
|
||
fn y(&self) -> Self::T { | ||
self.0[1] | ||
} | ||
|
||
fn nth_unchecked(&self, n: usize) -> Self::T { | ||
self.0[n] | ||
} | ||
} | ||
|
||
impl geo_traits::CoordTrait for &PointType { | ||
type T = f64; | ||
|
||
fn dim(&self) -> Dimensions { | ||
PointType::dim(self) | ||
} | ||
|
||
fn x(&self) -> Self::T { | ||
PointType::x(self) | ||
} | ||
|
||
fn y(&self) -> Self::T { | ||
PointType::y(self) | ||
} | ||
|
||
fn nth_unchecked(&self, n: usize) -> Self::T { | ||
PointType::nth_unchecked(self, n) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you feel about making this a default dependency? I wouldn't imagine it would add too much to compilation time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me! As long as we keep it optional