Add FromIterator impl for FeatureCollection #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh right... shoot.
The FromIterator implementation looks great to me.
I don't have anything handy. |
|
Added some minimal test and minor updates to the docs. The main page doc already quite nicely explains how to convert from geo-types, so I just added an example in the Addresses #170 to some extent |
michaelkirk
approved these changes
Aug 19, 2021
|
Very happy for this to merge! |
|
bors r=michaelkirk |
|
🔒 Permission denied Existing reviewers: click here to make rmanoka a reviewer |
|
bors r=michaelkirk |
|
🔒 Permission denied Existing reviewers: click here to make lnicola a reviewer |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Implementation Checklist
To summarize, this is the impl. checklist I'm suggesting:
FromIterator for FeatureCollectionFrom<&'a T> for Feature where From<&'a T> for Value, T: BoundingRectand 2 above@michaelkirk @urschrei I realize we can't use
BoundingRectas we only depend ongeo-types. Now, I'm a bit hesitant to add impl from geo-types ->Featuregiven it's just a conversion toValue, then toFeature. The users could do this themselves by converting toValuethen using.into()method.The PR currently just adds
FromIteratorimpl. Should add some tests for this; have an examples collections with bbox to try out with? We could also improve the docs forValue; currently it is hidden deep, and doesn't explain usage.